refactor: address review feedback on Community resolver

This commit is contained in:
copilot-swe-agent[bot]
2026-06-22 22:11:16 +00:00
committed by GitHub
parent 651865a8a8
commit 05917d5627
2 changed files with 8 additions and 6 deletions
+5 -4
View File
@@ -79087,6 +79087,7 @@ const GRAALVM_COMMUNITY_RELEASES_URL = 'https://api.github.com/repos/graalvm/gra
const GRAALVM_COMMUNITY_RELEASES_PAGE_ORIGIN = 'https://api.github.com';
const GRAALVM_COMMUNITY_DOWNLOAD_URL = 'https://github.com/graalvm/graalvm-ce-builds/releases';
const GRAALVM_COMMUNITY_ASSET_PREFIX = 'graalvm-community-jdk-';
const GRAALVM_COMMUNITY_VERSION_PATTERN = /^\d+(?:\.\d+)*$/;
const IS_WINDOWS = process.platform === 'win32';
const GRAALVM_PLATFORM = IS_WINDOWS ? 'windows' : process.platform;
const GRAALVM_MIN_VERSION = 17;
@@ -79292,14 +79293,14 @@ class GraalVMCommunityDistribution extends GraalVMDistribution {
});
}
getAvailableVersions(assetSuffix) {
var _a, _b;
var _a;
return __awaiter(this, void 0, void 0, function* () {
const headers = (0, util_1.getGitHubHttpHeaders)();
const versions = new Map();
let releasesUrl = GRAALVM_COMMUNITY_RELEASES_URL;
for (let page = 0; releasesUrl && page < util_1.MAX_PAGINATION_PAGES; page++) {
const response = yield this.http.getJson(releasesUrl, headers);
const releases = (_a = response.result) !== null && _a !== void 0 ? _a : [];
const releases = Array.isArray(response.result) ? response.result : [];
if (releases.length === 0) {
break;
}
@@ -79307,7 +79308,7 @@ class GraalVMCommunityDistribution extends GraalVMDistribution {
if (release.draft || release.prerelease) {
continue;
}
for (const asset of (_b = release.assets) !== null && _b !== void 0 ? _b : []) {
for (const asset of (_a = release.assets) !== null && _a !== void 0 ? _a : []) {
const version = this.extractAssetVersion(asset.name, assetSuffix);
if (version) {
versions.set(version, {
@@ -79330,7 +79331,7 @@ class GraalVMCommunityDistribution extends GraalVMDistribution {
return null;
}
const rawVersion = assetName.slice(GRAALVM_COMMUNITY_ASSET_PREFIX.length, -assetSuffix.length);
if (!/^\d+(?:\.\d+)*$/.test(rawVersion)) {
if (!GRAALVM_COMMUNITY_VERSION_PATTERN.test(rawVersion)) {
return null;
}
return (0, util_1.convertVersionToSemver)(rawVersion);
+3 -2
View File
@@ -31,6 +31,7 @@ const GRAALVM_COMMUNITY_RELEASES_PAGE_ORIGIN = 'https://api.github.com';
const GRAALVM_COMMUNITY_DOWNLOAD_URL =
'https://github.com/graalvm/graalvm-ce-builds/releases';
const GRAALVM_COMMUNITY_ASSET_PREFIX = 'graalvm-community-jdk-';
const GRAALVM_COMMUNITY_VERSION_PATTERN = /^\d+(?:\.\d+)*$/;
const IS_WINDOWS = process.platform === 'win32';
const GRAALVM_PLATFORM = IS_WINDOWS ? 'windows' : process.platform;
const GRAALVM_MIN_VERSION = 17;
@@ -386,7 +387,7 @@ export class GraalVMCommunityDistribution extends GraalVMDistribution {
headers
);
const releases = response.result ?? [];
const releases = Array.isArray(response.result) ? response.result : [];
if (releases.length === 0) {
break;
}
@@ -431,7 +432,7 @@ export class GraalVMCommunityDistribution extends GraalVMDistribution {
-assetSuffix.length
);
if (!/^\d+(?:\.\d+)*$/.test(rawVersion)) {
if (!GRAALVM_COMMUNITY_VERSION_PATTERN.test(rawVersion)) {
return null;
}