mirror of
https://github.com/actions/setup-java.git
synced 2026-07-04 13:10:20 +03:00
Updated jetbrains test: https.request() now catches errors. This fixes leaking tests as well (#1070)
* Updated jetbrains https.request command to catch errors. This fixes leaking tests as well * Removed deprecated lines from pre-commit and pre-push * added suggestion from PR feedback
This commit is contained in:
@@ -1,4 +1 @@
|
|||||||
#!/usr/bin/env sh
|
|
||||||
. "$(dirname -- "$0")/_/husky.sh"
|
|
||||||
|
|
||||||
npx lint-staged
|
npx lint-staged
|
||||||
|
|||||||
@@ -1,4 +1 @@
|
|||||||
#!/usr/bin/env sh
|
|
||||||
. "$(dirname -- "$0")/_/husky.sh"
|
|
||||||
|
|
||||||
npm run build && npm test
|
npm run build && npm test
|
||||||
|
|||||||
@@ -87,10 +87,26 @@ describe('findPackageForDownload', () => {
|
|||||||
const url = resolvedVersion.url;
|
const url = resolvedVersion.url;
|
||||||
const options = {method: 'HEAD'};
|
const options = {method: 'HEAD'};
|
||||||
|
|
||||||
https.request(url, options, res => {
|
await new Promise<void>((resolve, reject) => {
|
||||||
// JetBrains uses 403 for inexistent packages
|
const request = https.request(url, options, res => {
|
||||||
|
let assertionError: unknown;
|
||||||
|
|
||||||
|
try {
|
||||||
|
// JetBrains uses 403 for non-existent packages
|
||||||
expect(res.statusCode).not.toBe(403);
|
expect(res.statusCode).not.toBe(403);
|
||||||
|
} catch (error) {
|
||||||
|
assertionError = error;
|
||||||
|
}
|
||||||
|
|
||||||
res.resume();
|
res.resume();
|
||||||
|
res.once('error', reject);
|
||||||
|
res.once('end', () =>
|
||||||
|
assertionError ? reject(assertionError as Error) : resolve()
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
request.on('error', reject);
|
||||||
|
request.end();
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|||||||
Reference in New Issue
Block a user